fix: Case-insensitive globals matching (#684)#685
Merged
amilajack merged 1 commit intoamilajack:mainfrom Mar 2, 2026
Merged
Conversation
vsalomaki
force-pushed
the
fix/684-case-sensitivity-browser-globals
branch
from
b576a07 to
7c79f50
Compare
* Use case-insensitive objectname matching only for matching browserglobals
vsalomaki
force-pushed
the
fix/684-case-sensitivity-browser-globals
branch
from
7c79f50 to
0fdb0d1
Compare
|
🎉 This PR is included in version 7.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case-insensitive matching of browser globals was way too broad as implemented in #681 and as reported in #684.
This PR narrows the scope of the object-name matching by first finding the name from the globals.browser case-sensitively.
If found from globals, then use case-insensitive comparison of the object-names. Otherwise use simple case-sensitive matching.
Add tests for both "valid" cases and "invalid" cases.